[1.x] Increase query count in excessive TCP query tests#240
Merged
clue merged 1 commit intoreactphp:1.xfrom Oct 13, 2025
Merged
Conversation
This ports reactphp#237 from 3.x to 1.x. In a recent Ubuntu 24.04 runner update something changed that makes PHP code seemingly more performant. In reactphp#236 this issue is shown to have something to do with 24.04 because without code changes it works on 22.04. However, that doesn't fix the underlying issue. While I'm not sure what changed, by increasing these two numbers by 10 folding them we're back at passing tests.
clue
approved these changes
Oct 13, 2025
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@WyriHaximus Changes LGTM, thanks for cherry-picking!
For context: We discussed in person the build breaks on macOS only, this is already addressed in #239 which will only need a rebase once this is merged.
WyriHaximus
deleted the
1.x-increase-query-count-in-excessive-tcp-query-tests
branch
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Oct 13, 2025
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Oct 14, 2025
Builds on reactphp#240 and reactphp#218 by backporting reactphp#233 to v1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports #237 from 3.x to 1.x.
In a recent Ubuntu 24.04 runner update something changed that makes PHP code seemingly more performant. In #236 this issue is shown to have something to do with 24.04 because without code changes it works on 22.04. However, that doesn't fix the underlying issue.
While I'm not sure what changed, by increasing these two numbers by 10 folding them we're back at passing tests.